Fix sync issue in profiler tests #46907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon Issue DetailsFixes #46844 The macros introduced with #46739 had a bug. Because I was on autopilot and used
|
davmason
commented
Jan 13, 2021
| @@ -307,8 +307,6 @@ HRESULT STDMETHODCALLTYPE SlowPathELTProfiler::LeaveCallback(FunctionIDOrClientI | |||
|
|
|||
| HRESULT STDMETHODCALLTYPE SlowPathELTProfiler::TailcallCallback(FunctionIDOrClientID functionIdOrClientID, COR_PRF_ELT_INFO eltInfo) | |||
| { | |||
| SHUTDOWNGUARD(); | |||
There was a problem hiding this comment.
This is superfluous since it's already protected in TailcallStub above.
sdmaclea
approved these changes
Jan 13, 2021
hoyosjs
approved these changes
Jan 13, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46844
The macros introduced with #46739 had a bug. Because I was on autopilot and used
do{...} while(0)in the macros, it introduced a new scope and the ShutdownGuard class would not be held for the duration of the call. I did test it, since it prevented new calls from entering the profiler code it drastically reduced the hit rate but there still was a race condition.