Revert "Enable non-blittable struct returns on UnmanagedCallersOnly (#45625)" #46172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit caused the rolling build to break when running tests. There are various symptoms here like crashes or test failures because a wrong value is returned.
https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-master-db730bf754b04385ad/PayloadGroup0/console.22213a03.log?sv=2019-07-07&se=2021-01-05T20:49:15Z&sr=c&sp=rl&sig=Ms13Vjh0e7qy3habeZFOis96Fx%2BgijRAnLgpkflACvk%3D
https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-master-9dcde7f053014a80a1/System.Collections.Tests/console.82eb4f6b.log?sv=2019-07-07&se=2021-01-05T19%3A40%3A21Z&sr=c&sp=rl&sig=VAqIZP6UszpjxQrfkUsXjn%2BZXls0jLc8ly3k63YCR6c%3D
https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-master-0e44ba7fc5b24350b4/System.Runtime.Numerics.Tests/console.f91e83a2.log?sv=2019-07-07&se=2021-01-05T19%3A38%3A53Z&sr=c&sp=rl&sig=9lF%2FPpk6%2FpUZ2bAEAcQtkoZTkNFuKVINxeg%2BrH8ZtRI%3D
The PR Build for #45625 was green. The reason for that is that this only manifests when running on 64 bit on release and it wasn't caught due to not having any configuration for libraries on release running tests on this archs. @jkoritzinsky will follow up on that to run Libraries Release on a Checked CoreCLR on PRs.
cc: @jkoritzinsky @jkotas @akoeplinger