Skip to content

Revert "Enable non-blittable struct returns on UnmanagedCallersOnly (#45625)" #46172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

safern
Copy link
Member

@safern safern commented Dec 16, 2020

This commit caused the rolling build to break when running tests. There are various symptoms here like crashes or test failures because a wrong value is returned.

Fatal error. System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
         at System.Buffer.Memmove(Byte ByRef, Byte ByRef, UIntPtr)
         at System.Runtime.InteropServices.Marshal.CopyToManaged[[System.Byte, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](IntPtr, Byte[], Int32, Int32)
         at System.Reflection.BlobUtilities.ReadBytes(Byte*, Int32)

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-master-db730bf754b04385ad/PayloadGroup0/console.22213a03.log?sv=2019-07-07&se=2021-01-05T20:49:15Z&sr=c&sp=rl&sig=Ms13Vjh0e7qy3habeZFOis96Fx%2BgijRAnLgpkflACvk%3D

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-master-9dcde7f053014a80a1/System.Collections.Tests/console.82eb4f6b.log?sv=2019-07-07&se=2021-01-05T19%3A40%3A21Z&sr=c&sp=rl&sig=VAqIZP6UszpjxQrfkUsXjn%2BZXls0jLc8ly3k63YCR6c%3D

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-master-0e44ba7fc5b24350b4/System.Runtime.Numerics.Tests/console.f91e83a2.log?sv=2019-07-07&se=2021-01-05T19%3A38%3A53Z&sr=c&sp=rl&sig=9lF%2FPpk6%2FpUZ2bAEAcQtkoZTkNFuKVINxeg%2BrH8ZtRI%3D

The PR Build for #45625 was green. The reason for that is that this only manifests when running on 64 bit on release and it wasn't caught due to not having any configuration for libraries on release running tests on this archs. @jkoritzinsky will follow up on that to run Libraries Release on a Checked CoreCLR on PRs.

cc: @jkoritzinsky @jkotas @akoeplinger

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@safern
Copy link
Member Author

safern commented Dec 16, 2020

I confirmed that this broke the build by queueing a build without that commit and everything passed:
https://dnceng.visualstudio.com/public/_build/results?buildId=924035&view=results

@BruceForstall
Copy link
Contributor

@kunalspathak maybe this is related to the problem of the superpmi collection being broken?

@jkotas
Copy link
Member

jkotas commented Dec 17, 2020

Fixed by #46176

@jkotas jkotas closed this Dec 17, 2020
@safern safern deleted the RevertNonBlitableStructReturns branch December 17, 2020 04:56
@ghost ghost locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants