Close accept loop when closing connection #44885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue Details
|
halter73
reviewed
Nov 19, 2020
src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicConnection.cs
Outdated
Show resolved
Hide resolved
jkotalik
force-pushed
the
jkotalik/CloseAcceptOnAbort
branch
from
3351d86 to
f0fa27f
Compare
|
Verified this works locally. |
|
There are other issues I'm hitting locally, but will investigate in another PR. |
halter73
reviewed
Nov 25, 2020
src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicListener.cs
Show resolved
Hide resolved
halter73
reviewed
Nov 25, 2020
src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicListener.cs
Outdated
Show resolved
Hide resolved
halter73
approved these changes
Nov 25, 2020
…ons/MsQuic/MsQuicListener.cs Co-authored-by: Stephen Halter <halter73@gmail.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when working on dotnet/aspnetcore#26638 in the aspnetcore repo.
When closing the connection by a call to CloseAsync, it makes sense to force the accept loop to close. Other scenarios like Abort from client and Abort from transport already close the channel.