Convert aka.ms links to https #44501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabYourPitchforks
requested review from
akoeplinger,
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
|
Looking at the reviewer list, GitHub looks like it touched the world w.r.t. area ownership. Hooray, I guess? |
akoeplinger
approved these changes
Nov 11, 2020
src/coreclr/src/pal/inc/rt/sal.h
Outdated
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| The comments in this file are intended to give basic understanding of | |||
| the usage of SAL, the Microsoft Source Code Annotation Language. | |||
| For more details, please see https://go.microsoft.com/fwlink/?LinkID=242134 | |||
| For more details, please see http://go.microsoft.com/fwlink/?LinkID=242134 | |||
There was a problem hiding this comment.
why did you revert this one, it doesn't look like a generated file?
There was a problem hiding this comment.
This file appears to have been copied verbatim from the VC++ SDK. The only thing we added was a header at the top of the file. I didn't want to change any of its contents.
stephentoub
approved these changes
Nov 11, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts aka.ms and go.microsoft.com links throughout our markdown files, source comments, and error strings from http to https.
Note: Some files (like web.config) I intentionally left unchanged since they're auto-generated by tools, and the tool spits out an http link. I divided this PR into two commits to make this a bit clearer. The first commit touches all occurrences; the second commit calls out files that we shouldn't change and reverts them.
I originally wanted to send a larger PR that touches a bunch of files, including links to http://*.microsoft.com/blah, but it ended up becoming very noisy because I had to make sure we weren't touching XML schemas and related files. I'm thinking the easiest thing to do might be to send a few piecemeal PRs so that they're each easier to review independently.
There are no behavioral code changes as part of this PR. However, there are intentional resource string and obsoletion message changes.