Skip to content

Add interpreter libraries to iOS device runtime pack #43944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2020
Merged

Add interpreter libraries to iOS device runtime pack #43944

merged 1 commit into from
Oct 28, 2020

Conversation

akoeplinger
Copy link
Member

Fixes #43943

@akoeplinger akoeplinger requested review from vargaz and EgorBo October 28, 2020 12:27
@steveisok
Copy link
Member

Can we enable for Android too while we're at it?

@akoeplinger
Copy link
Member Author

akoeplinger commented Oct 28, 2020 •
edited
Loading

@steveisok Android builds already contain the interpreter in libmonosgen-2.0.so I think. turns out I looked at the wrong line, it seems to be disabled.

@akoeplinger akoeplinger merged commit ec26ee5 into dotnet:master Oct 28, 2020
@akoeplinger akoeplinger deleted the ios-interp branch October 28, 2020 14:10
@ghost ghost locked as resolved and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorBo EgorBo EgorBo approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@vargaz vargaz Awaiting requested review from vargaz

Assignees
No one assigned
Labels
area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mono: the runtime packages for .NET 6+ for iOS/tvOS/watchOS do not contain the static libraries required for interpreter support
3 participants
@akoeplinger @steveisok @EgorBo