Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable implicit fallthrough warning #43397

Merged
merged 14 commits into from
Oct 21, 2020
Merged

Enable implicit fallthrough warning #43397

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e1b35f1
Enable implicit fallthrough warning
janvorli Oct 14, 2020
8c409ba
Fix ARM build
janvorli Oct 14, 2020
824ec9b
Fix libraries build
janvorli Oct 14, 2020
2843684
Fix OSX
janvorli Oct 14, 2020
2ed53ab
Reflect PR feedback
janvorli Oct 14, 2020
720685f
Fix issue with clang < 10
janvorli Oct 14, 2020
1b95902
Minor fix
janvorli Oct 14, 2020
0b63faa
Fix build with clang 9
janvorli Oct 14, 2020
002ec2f
Remove incorrectly added unreachable
janvorli Oct 16, 2020
fb67fd9
Apply formatting patch
janvorli Oct 16, 2020
f60ee19
Cleanup
janvorli Oct 16, 2020
93fa490
Reflect PR feedback
janvorli Oct 19, 2020
d99f6b9
Replace __fallthrough by FALLTHROUGH
janvorli Oct 19, 2020
147c085
Add break to Compiler::fgCreateLoopPreHeade switch
janvorli Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reflect PR feedback
  • Loading branch information
@janvorli
janvorli committed Oct 14, 2020
commit 2ed53abcfd34c6ef3ca9a6467ccad9b8a5f33d75
2 changes: 1 addition & 1 deletion src/coreclr/src/jit/lower.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6278,7 +6278,7 @@ void Lowering::ContainCheckNode(GenTree* node)
break;
case GT_STOREIND:
ContainCheckStoreIndir(node->AsIndir());
__fallthrough; // TODO: is this actually a bug?
break;
case GT_IND:
ContainCheckIndir(node->AsIndir());
break;
Expand Down
1 change: 1 addition & 0 deletions src/coreclr/src/jit/lowerxarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5594,6 +5594,7 @@ void Lowering::ContainCheckHWIntrinsic(GenTreeHWIntrinsic* node)
}
}
}
unreached();
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use unreached(); break; in such cases?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandreenko in the CI run, 15 coreclr tests have failed due to this added unreachable. So it seems it should be just a break here. I guess the fall through that was here before was benign, as the switch in the case below would end up in the default and nothing wrong would happen.

}

Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/jit/optcse.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3633,7 +3633,7 @@ bool Compiler::optIsCSEcandidate(GenTree* tree)
{
return false;
}
__fallthrough;
return true;

case GT_EQ:
case GT_NE:
Expand Down