-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(MQ cleanup) Remove some unsafe code from System.Xml #43379
Merged
GrabYourPitchforks
merged 10 commits into
dotnet:master
from
GrabYourPitchforks:mq_cleanup
Nov 3, 2020
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1a31b76
Remove private DoubleToInt64Bits
GrabYourPitchforks cb2b6fd
Remove unsafe IntToString implementation
GrabYourPitchforks d19f99d
Remove unsafe AdjustLineInfo implementation
GrabYourPitchforks 74684f0
Remove unsafe GetStringAligned implementation
GrabYourPitchforks 2cdeefa
Remove unsafe code from BinHexDecoder
GrabYourPitchforks e6de742
Remove unsafe MemoryMarshal usage from CodeIdentifier
GrabYourPitchforks af2355e
Remove unsafe Base64Decoder implementation
GrabYourPitchforks 6ebfdef
Remove unsafe code in GetSingle and GetDouble
GrabYourPitchforks 7dba9f6
Remove unsafe code from CheckText
GrabYourPitchforks aed0874
Merge remote-tracking branch 'origin/master' into mq_cleanup
GrabYourPitchforks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove unsafe IntToString implementation
- Loading branch information
commit cb2b6fd597dcc199379bc485cb2d95c79cbfff5e
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed custom implementation in favor of delegating to the runtime's already-optimized
int.ToString
implementation.On .NET 5/6, dereferencing
CultureInfo.InvariantCulture
is very fast due to recent JIT optimizations.