[release/5.0-rc2] Fix issue with covariant return method validation #41734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The ClassLoader::ValidateMethodsWithCovariantReturnTypes was being called from a place where the relevant types were sometimes not fully loaded yet. That resulted in an attempt to load the type being loaded recursively, which was detected and the TypeLoadException was thrown. This change fixes it by moving the call to the ClassLoader::ValidateMethodsWithCovariantReturnTypes to the PushFinalLevels when the level is greater than CLASS_LOAD_EXACTPARENTS, which is the last stage of normal loading.
davidwrighton
approved these changes
Sep 2, 2020
jeffschwMSFT
approved these changes
Sep 3, 2020
jamshedd
added
Servicing-approved
|
Approved for RC2. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41703 to release/5.0-rc2
/cc @janvorli
Customer Impact
Valid applications using covariant returns may fail with TypeLoadException.
Testing
Local testing via coreclr pri1 tests and libraries tests.
Risk
Low