Adding sequential read as the file option in ReadAllBytes

[RiskRunner0]

Fixing #40001, adding Sequential Read file option for ReadAllBytes in File.cs.

[Dotnet-GitSync-Bot]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[danmoseley]

This seems reasonable/safe, we already use SequentialScan for other similar methods, and StreamReader/StreamWriter always use it (thus also File.ReadAllText, WriteAllText etc)

What about File.InternalWriteAllBytes, WriteAllTextAsync, and AppendAllTextAsync. Should those have it?

[RiskRunner0]

I think that makes sense, I'd want to validate it with someone else though (relatively new to .NET contributing and internals) so cc: @jkotas thoughts?

[jkotas]

What about File.InternalWriteAllBytes, WriteAllTextAsync, and AppendAllTextAsync. Should those have it?

https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilea#caching-behavior says that FILE_FLAG_SEQUENTIAL_SCAN helps with reading. It does not say anything about writing.

[danmoseley]

@jkotas, right but I see it's on StreamWriter even in .NET Framework.
https://source.dot.net/#System.Private.CoreLib/StreamWriter.cs,169

[jkotas]

If we were do add it to the file writing helpers, I would like to see data that prove it helps and does not hurt.

[danmoseley]

For sure. Anyway I think this change can go ahead as its.

[jkotas]

@QueenCitySmitty Thank you!

[RiskRunner0]

@jkotas thank YOU for letting me contribute.. first time! :D

[danmoseley]

@QueenCitySmitty you are welcome here. Would you be interested in another contribution? eg
up for grabs: https://github.com/dotnet/runtime/issues?q=is%3Aopen+is%3Aissue+label%3Aup-for-grabs+
easy: https://github.com/dotnet/runtime/issues?q=is%3Aopen+is%3Aissue+label%3Aeasy

anything marked milestone 5.0 would be even better.

[RiskRunner0]

Found this one in Up for Grabs, going to keep poking there, thanks for the encouragement!