Skip to content

[WIP] Fix setting creation date for OSX #39263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[WIP] Fix setting creation date for OSX #39263

wants to merge 7 commits into from

Conversation

hamarb123
Copy link
Contributor

See issue #39132. WIP.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 14, 2020
@hamarb123 hamarb123 marked this pull request as draft July 14, 2020 09:52
@hamarb123 hamarb123 changed the title [WIP] Fix setting creation date for OSX [WIP] Fix setting creation date for OSX (#39132) Jul 14, 2020
@hamarb123 hamarb123 changed the title [WIP] Fix setting creation date for OSX (#39132) [WIP] Fix setting creation date for OSX Jul 14, 2020
hamarb123 added 2 commits July 15, 2020 11:23
@hamarb123
Try not caching (#39132)
6abaf66 
There was a 'SIGSEGV Illegal memory access' that seemed related to this, this should fix it.
@hamarb123
Add missing vars (#39132)
63fde7a
@danmoseley
Copy link
Member

You should be able to spread FileStatus over several files as a partial struct in order to share as much as possible with the "other Unix" and have an OSX file only for the Mac specific members. This is a pattern we use all over the sources. Eg., FileSystemEntry.*.cs

@danmoseley danmoseley added area-System.IO and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jul 15, 2020
@hamarb123
Copy link
Contributor Author

You should be able to spread FileStatus over several files as a partial struct in order to share as much as possible with the "other Unix" and have an OSX file only for the Mac specific members. This is a pattern we use all over the sources. Eg., FileSystemEntry.*.cs

@danmosemsft okay, I will fix that shortly.

@danmoseley
Copy link
Member

Thanks for working on this. It might be best to close this PR and reopen when you're ready for review. I assume you have a mac locally to build and test on.

If you have it open like this, it uses up a lot of CI time. Each time you push it kicks off a gazillion new jobs involving 10's or 100 machines even if it's just to fix a typo. Better to work locally, get tests passing locally, then create the PR when you're ready for review and CI.

@hamarb123
Copy link
Contributor Author

@danmosemsft okay, I will do that.

@hamarb123 hamarb123 closed this Jul 15, 2020
@jaredpar jaredpar mentioned this pull request Jul 15, 2020
Closed
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area-System.IO
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hamarb123 @danmoseley @karelz @Dotnet-GitSync-Bot