[Wasm] Enable System.IO.Compression.ZipFile tests #39092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found that the emscripten VFS does not write user specified file attributes, so skip part of ZipFile_Create.InvalidDates that expects this to be supported.
|
Emscripten VFS write function, for reference: |
safern
approved these changes
Jul 10, 2020
stephentoub
approved these changes
Jul 10, 2020
akoeplinger
approved these changes
Jul 10, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that the emscripten VFS may not write user specified file attributes (at least initially), so skip the part of ZipFile_Create.InvalidDates that expects this to be supported.