Skip to content

[browser][wasm][tests] JavaScript Interop Marshal tests #38917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 13, 2020
Merged

[browser][wasm][tests] JavaScript Interop Marshal tests #38917

merged 17 commits into from
Jul 13, 2020

Conversation

kjpou1
Copy link
Contributor

@kjpou1 kjpou1 commented Jul 8, 2020

No description provided.

MaximLipnin
MaximLipnin reviewed Jul 8, 2020
View reviewed changes
@kjpou1
Add tests for object identity across marshaling calls for JS object a…
8b1c4af 
…nd managed objects.

- Tests to make sure the objects stay the same and are not created new.
@jaredpar jaredpar mentioned this pull request Jul 8, 2020
Closed
@safern safern mentioned this pull request Jul 8, 2020
Closed
@kjpou1 kjpou1 marked this pull request as ready for review July 10, 2020 04:29
@kjpou1 kjpou1 requested a review from MaximLipnin July 10, 2020 04:29
kjpou1 added 2 commits July 10, 2020 06:36
@kjpou1
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
582e954 
…tests-marshal

# Conflicts:
#	src/libraries/System.Runtime.InteropServices.JavaScript/tests/System.Runtime.InteropServices.JavaScript.Tests.csproj
@kjpou1
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
8ca0c83 
…tests-marshal

# Conflicts:
#	src/libraries/System.Runtime.InteropServices.JavaScript/tests/System.Runtime.InteropServices.JavaScript.Tests.csproj
MaximLipnin
MaximLipnin reviewed Jul 13, 2020
View reviewed changes
@kjpou1 kjpou1 requested a review from MaximLipnin July 13, 2020 09:06
@kjpou1 kjpou1 merged commit 2d9dbbb into dotnet:master Jul 13, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MaximLipnin MaximLipnin MaximLipnin approved these changes

@lewing lewing Awaiting requested review from lewing

@vargaz vargaz Awaiting requested review from vargaz

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@steveisok steveisok Awaiting requested review from steveisok

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjpou1 @MaximLipnin @marek-safar @Dotnet-GitSync-Bot