Skip to content

[wasm] Skip System.Net.WebClient test suite #38857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2020
Merged

[wasm] Skip System.Net.WebClient test suite #38857

merged 2 commits into from
Jul 7, 2020

Conversation

MaximLipnin
Copy link
Contributor

@MaximLipnin MaximLipnin commented Jul 7, 2020 •
edited
Loading

Part of #38422.

Actually System.Net.WebClient test suite crashes with the error described in #38807. But since WebClient class is not recommended for new development, I just skipped the respective tests on WASM.
Besides that, I updated System.Net.WebClient with throwing PNSE on wasm.

@ghost
Copy link

ghost commented Jul 7, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@steveisok steveisok mentioned this pull request Jul 7, 2020
Closed
99 tasks
@akoeplinger
Copy link
Member

akoeplinger commented Jul 7, 2020 •
edited
Loading

Looks good but I think we should also add PNSE for System.Net.WebClient and point people to HttpClient.

@stephentoub
Copy link
Member

Looks good but I think we should also add PNSE for System.Net.WebClient and point people to HttpClient.

The async APIs on WebClient should still work, right? It's just the sync ones that won't?

(I don't have a strong opinion here; if we want to PNSE the whole assembly because it's legacy and not recommended for new use, ok.)

@akoeplinger
Copy link
Member

akoeplinger commented Jul 7, 2020 •
edited
Loading

@stephentoub yeah that would probably work but I just checked and WebClient never worked in the mono/mono-based WASM so I think we should be fine with marking it PNSE here.

@MaximLipnin could you please add that? With this message: System.Net.WebClient is not supported on this platform. Use System.Net.Http.HttpClient instead.

@stephentoub
Copy link
Member

yeah that would probably work but I just checked and WebClient never worked in the mono/mono-based WASM so I think we should be fine with marking it PNSE here.

Ok

@akoeplinger akoeplinger merged commit 8f25c04 into dotnet:master Jul 7, 2020
@akoeplinger akoeplinger mentioned this pull request Jul 7, 2020
Merged
@MaximLipnin MaximLipnin deleted the wasm_WebClient branch July 7, 2020 20:25
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@stephentoub stephentoub stephentoub approved these changes

@steveisok steveisok Awaiting requested review from steveisok

@mdh1418 mdh1418 Awaiting requested review from mdh1418

Assignees
No one assigned
Labels
area-System.Net
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MaximLipnin @akoeplinger @stephentoub @karelz @Dotnet-GitSync-Bot