Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask about prior art in API review template #38727

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Ask about prior art in API review template #38727

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9d9f83
Ask about prior art in API review template
danmoseley Jul 2, 2020
75f706e
Update .github/ISSUE_TEMPLATE/02_api_proposal.md
stephentoub Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Ask about prior art in API review template 
As an example, #35088 described an analogous pattern in the Go ecosystem. While we have distinct patterns and rules for .NET API, if there's analogous prior art it may be interesting to compare approaches.
  • Loading branch information
@danmoseley
danmoseley authored Jul 2, 2020
commit a9d9f835f1a62f307751872f1b141cbe43855d23
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/02_api_proposal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ You can use code blocks like this:

<!--
Were there other options you considered, such as alternative API shapes?
How does this compare to analogous APIs in other ecosystems and libraries, if known?
stephentoub marked this conversation as resolved.
Show resolved Hide resolved
-->

## Risks
Expand Down