-
Notifications
You must be signed in to change notification settings - Fork 5.1k
July infra rollout: Move runtime tests out of the coreclr folder (2nd attempt) #38058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -109,7 +109,9 @@ jobs: | |
- eng/pipelines/installer/* | ||
- subset: runtimetests | ||
include: | ||
- src/tests/* | ||
- src/coreclr/tests/* | ||
- src/coreclr/build-test.cmd | ||
safern marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- src/coreclr/build-test.sh | ||
- subset: installer | ||
include: | ||
|
@@ -151,6 +153,7 @@ jobs: | |
condition: >- | ||
or( | ||
eq(dependencies.checkout.outputs['SetPathVars_coreclr.containsChange'], true), | ||
eq(dependencies.checkout.outputs['SetPathVars_runtimetests.containsChange'], true), | ||
eq(variables['isFullMatrix'], true)) | ||
|
||
# | ||
|
@@ -187,6 +190,7 @@ jobs: | |
or( | ||
eq(dependencies.checkout.outputs['SetPathVars_coreclr.containsChange'], true), | ||
eq(dependencies.checkout.outputs['SetPathVars_libraries.containsChange'], true), | ||
eq(dependencies.checkout.outputs['SetPathVars_runtimetests.containsChange'], true), | ||
eq(variables['isFullMatrix'], true)) | ||
|
||
# | ||
|
@@ -598,6 +602,7 @@ jobs: | |
eq(dependencies.checkout.outputs['SetPathVars_libraries.containsChange'], true), | ||
eq(dependencies.checkout.outputs['SetPathVars_coreclr.containsChange'], true), | ||
eq(dependencies.checkout.outputs['SetPathVars_mono.containsChange'], true), | ||
eq(dependencies.checkout.outputs['SetPathVars_runtimetests.containsChange'], true), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just double checking to refresh my memory, libraries tests are needed for runtime tests, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we need any library test build artifacts for building or running runtime tests, just the libraries build. I can easily remove this line if you believe it's superfluous, I guess I'll probably catch a few more conflicts before the night is over, I just hope that around PST midnight the churn will calm down a bit. I'm not going to update the PR right away as that would cancel the running tests and that would be a waste of lab resources considering this is ultimately just a "perf optimization". There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can update this as a subsequent PR to not risk getting more merge conflicts. |
||
eq(variables['isFullMatrix'], true)) | ||
|
||
# | ||
|
@@ -635,6 +640,7 @@ jobs: | |
condition: >- | ||
or( | ||
eq(dependencies.checkout.outputs['SetPathVars_coreclr.containsChange'], true), | ||
eq(dependencies.checkout.outputs['SetPathVars_runtimetests.containsChange'], true), | ||
eq(variables['isFullMatrix'], true)) | ||
|
||
# | ||
|
@@ -658,6 +664,7 @@ jobs: | |
condition: >- | ||
or( | ||
eq(dependencies.checkout.outputs['SetPathVars_coreclr.containsChange'], true), | ||
eq(dependencies.checkout.outputs['SetPathVars_runtimetests.containsChange'], true), | ||
eq(variables['isFullMatrix'], true)) | ||
|
||
- template: /eng/pipelines/common/platform-matrix.yml | ||
|
@@ -677,6 +684,7 @@ jobs: | |
condition: >- | ||
or( | ||
eq(dependencies.checkout.outputs['SetPathVars_coreclr.containsChange'], true), | ||
eq(dependencies.checkout.outputs['SetPathVars_runtimetests.containsChange'], true), | ||
eq(variables['isFullMatrix'], true)) | ||
|
||
# | ||
|
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<Import Project="../coreclr/tests/src/Directory.Build.props" /> | ||
</Project> |
Uh oh!
There was an error while loading. Please reload this page.