[mono] Initial static ICU implementation for wasm #38057
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorBo
requested review from
alexischr,
CoffeeFlux,
lambdageek,
marek-safar,
thaystg and
vargaz
as code owners
kg
reviewed
Jun 17, 2020
src/libraries/Native/Unix/System.Globalization.Native/pal_icushim_internal.h
Outdated
Show resolved
Hide resolved
|
Why is this needed ? Why can't we just link icu into the final wasm executable ? |
kg
added
NO-MERGE
|
@vargaz I am not sure I understand what you mean, the __Internal changes will be removed once Thays's PR for QCalls is merged. The rest is just to link static ICU files into the build (not only wasm but also supports desktop mono for tests) |
|
Closing due to #37971 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to try it:
clone ICU repo and build it via the following script:
https://github.com/kg/mono/blob/wasm-libicu/sdks/wasm/icu/build-icu.sh
set
export ICU_REPO=path/to/icu/repobuild dotnet/runtime for wasm.
cc @kg