Move Mono Linux_arm64 build to run when runtime tests change #37985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @ViktorHofer |
|
Heh, I actually just did a PR for the same thing: #37916. Who wants to go first? |
That happens for me not checking if there was a PR open for this. Let's use yours since yours already went through CI. |
|
Although it did not pass; I will need to make some additions to issues.targets and it will then need to go through CI again. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: #37859 changed the way hardware intrinsic tests were built but the Linux_arm64 Mono Runtime tests didn't run because the Mono Linux_arm64 product build was in the wrong template expansion which didn't run that leg if runtimetests subset was changed, causing the Linux_arm64 Mono runtime test to not run because it depends on the Mono product build, since the latter was skipped, the former didn't run.
With this change, both OSX and Linux_arm64 Mono runtime tests will be run when runtimetests subset is changed.
cc: @naricc @tannergooding