-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Make browser peer for windows_nt and unix #37944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
076a6e0
Make browser peer for windows_nt and unix
Anipik 8984d0b
fixing the build
Anipik f0a5663
fix open ssl failure
Anipik 5fb5e46
Merge branch 'master' into browser
Anipik 4291a66
Merge branch 'master' into browser
Anipik 6465a78
adding no warn back
Anipik 5d73150
fixing the unix build
Anipik 12b5aac
revert principal .windows change
Anipik fa8c20f
removing or property from tests
Anipik 8f959d4
fix wasm and allconfig build
Anipik bd4846a
Adding references for diagnostics.fileversion
Anipik 7e54485
missing dollar sign
Anipik e2f5315
fixing tests and manual facdes
Anipik d190c6b
fix odbc and facades
Anipik eb7e601
adding packageTargetRuntime for browser
Anipik 3846b38
minor change
Anipik dc2216e
fix netfx and allconfig build
Anipik 6ef1e48
Merge branch 'master' into browser
Anipik 1cc4f91
fix crypto stuff failure due non-supported tuff
Anipik d738f49
fizing the condition
Anipik ff27b9d
fix wasm build
Anipik e99173e
remove browser build
Anipik 5b0d663
adding the file
Anipik a5c65a0
add not supported for csp
Anipik 8e1d412
adding not supported for system.diagnostics.process
Anipik 2cae8b9
fix build
Anipik 1357ea5
fixinf wasm tests
Anipik c9d580a
Merge branch 'master' into browser
Anipik 60c9a7d
unblock
Anipik 5b2a012
Remove not supported file and use genapi features
Anipik 7ef5d6e
eric feedback
Anipik 2005c7d
Remove browser string from x509 certificates
Anipik a6a3ac3
non empty message to fix linux build failures
Anipik b6abf7d
exclude odbc32 from src of netstandard
Anipik 22cb722
correct built in alias
Anipik 5a11b72
correct the path
Anipik cc5b209
adding comment
Anipik 3d04c68
address feedback
Anipik 940b3a4
expose odbc32
Anipik 76c049b
Merge branch 'master' into browser
Anipik 9de7b73
addressing minor feedback and disabling tests
Anipik 7262a3a
running runtime chaching tests on browser
Anipik 613fb3b
disabling tests for wasm
Anipik a3a3413
correcting tfms for tests in runtime.interop services
Anipik ccfe841
fixingsome tests.csproj
Anipik 7c903f1
remove trailing semi colon
Anipik 7133cde
add comment
Anipik a5b294a
Merge branch 'master' into browser
Anipik 7db9dd4
Merge branch 'master' into browser
Anipik 50612c6
fix webclient merge conflict
Anipik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
src/libraries/Microsoft.Win32.Primitives/src/System/ComponentModel/Win32Exception.Default.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
namespace System.ComponentModel | ||
{ | ||
public partial class Win32Exception | ||
{ | ||
private static string GetErrorMessage(int error) => $"The process failed with error code {error}"; | ||
} | ||
} |
2 changes: 1 addition & 1 deletion
2
src/libraries/Microsoft.Win32.Primitives/tests/Microsoft.Win32.Primitives.Tests.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,9 +3,6 @@ | |
"Unix" : { | ||
}, | ||
"Browser" : { | ||
"#import": [ | ||
"Linux" | ||
] | ||
}, | ||
"Linux": { | ||
"#import": [ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
src/libraries/System.Data.Odbc/ref/System.Data.Odbc.ODBC32.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
namespace System.Data.Odbc | ||
{ | ||
[System.Runtime.CompilerServices.TypeForwardedFrom("System.Data, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")] | ||
public static class ODBC32 | ||
{ | ||
[System.Runtime.CompilerServices.TypeForwardedFrom("System.Data, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")] | ||
public enum RETCODE : int | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is this about? This needs a better comment at least. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added the comment in #38968. there is some more info on decision here #37944 (comment) |
||
{ | ||
SUCCESS = 0, | ||
SUCCESS_WITH_INFO = 1, | ||
ERROR = -1, | ||
INVALID_HANDLE = -2, | ||
NO_DATA = 100, | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.