Fix detection of static readonly field re-initialization via reflection #37849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am11
reviewed
Jun 13, 2020
|
/cc @vargaz @lambdageek this will need similar fix on Mono side |
Move the check for static readonly field re-initialization after the static constructor is triggered. Fixes dotnet#37796
I created an issue #37903 Looks like mono doesn't have a check in |
Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
sandreenko
pushed a commit
to sandreenko/runtime
that referenced
this pull request
Jun 17, 2020
…reflection (dotnet#37849)" This reverts commit d629976.
erozenfeld
added a commit
to erozenfeld/jitutils
that referenced
this pull request
Jun 19, 2020
I added a workaround for disassembly non-determinism in dotnet#255. See dotnet#255 for details of what causes the non-determinism. It turns it relied on a reflection hole that allowed init-only static fields to be modified after static constructor has been called. That hole was fixed in dotnet/runtime#37849 so the workaround is no longer valid and causes an exception from pmi. I don't see a way to work around the non-determinism without changing framework code so for now I'm just reverting the workaround. Unfortunately, that means that we can get non-deterministic disassembly for any method that inlines System.Threading.Thread.GetCurrentProcessorId. Fixes dotnet#271.
erozenfeld
added a commit
to dotnet/jitutils
that referenced
this pull request
Jun 19, 2020
I added a workaround for disassembly non-determinism in #255. See #255 for details of what causes the non-determinism. It turns it relied on a reflection hole that allowed init-only static fields to be modified after static constructor has been called. That hole was fixed in dotnet/runtime#37849 so the workaround is no longer valid and causes an exception from pmi. I don't see a way to work around the non-determinism without changing framework code so for now I'm just reverting the workaround. Unfortunately, that means that we can get non-deterministic disassembly for any method that inlines System.Threading.Thread.GetCurrentProcessorId. Fixes #271.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the check for static readonly field re-initialization after the static constructor is triggered.
Fixes #37796