Skip to content

Resetting _waitForCompletion to null was removed from DuplexContent #35010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2020
Merged

Resetting _waitForCompletion to null was removed from DuplexContent #35010

merged 3 commits into from
Apr 17, 2020

Conversation

@alnikola
Copy link
Contributor

@alnikola alnikola commented Apr 15, 2020

_waitForCompletion gets reset to null in DuplexContent.Complete and Fail which leads to race condition with SerializeToStreamAsync. This reset seems redundant since _waitForCompletion is always unconditionally initialized on each call to SerializeToStreamAsync. This PR removes that reset logic.

Fixes #33141

@alnikola alnikola requested a review from a team April 15, 2020 16:35
@ghost
Copy link

ghost commented Apr 15, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@davidsh davidsh added this to the 5.0 milestone Apr 15, 2020
@alnikola
Copy link
Contributor Author

alnikola commented Apr 15, 2020

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 15, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@jaredpar jaredpar mentioned this pull request Apr 15, 2020
Closed
@alnikola
Copy link
Contributor Author

alnikola commented Apr 16, 2020

/azp stop runtime

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 16, 2020

Command 'stop' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@alnikola
Copy link
Contributor Author

alnikola commented Apr 16, 2020

/azp help

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 16, 2020

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@alnikola
Copy link
Contributor Author

alnikola commented Apr 16, 2020

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 16, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@alnikola alnikola merged commit 9fd1e23 into dotnet:master Apr 17, 2020
@alnikola alnikola deleted the alnikola/33141-sendasync-concurent-send-receive-ok branch April 17, 2020 11:52
@jaredpar jaredpar mentioned this pull request Apr 17, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

+1 more reviewer

@davidsh davidsh davidsh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Net.Http

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

SendAsync_ConcurentSendReceive_Ok is failing in CI

4 participants

@alnikola @stephentoub @davidsh @Dotnet-GitSync-Bot