[CBOR] Implement support for tagged types #34767

eiriktsarpalis · 2020-04-09T15:30:31Z

Contributes to #32046 and #32047.

Implement PeekTag() method.
Implement DateTime type support.
Implement BigInteger support.
Implement decimal support.

Addendum:

Add WriteInt32()/ReadInt32() convenience methods.
Add pervasive buffer postcondition checks on negative reader tests and fix relevant bugs.
Rename "Special" major type to "Simple".

ghost · 2020-04-09T15:30:34Z

Tagging @bartonjs as an area owner

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Tag.cs

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborReaderTests.Tag.cs

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Tag.cs

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborWriter.Integer.cs

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborWriter.Tag.cs

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.cs

eiriktsarpalis · 2020-04-15T16:50:34Z

@bartonjs PR is now ready for review. There are still a few design issues to be considered, in the unresolved conversations above.

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborReaderTests.Tag.cs

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Tag.cs

eiriktsarpalis · 2020-04-17T14:42:29Z

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborWriter.Tag.cs

@tannergooding you might be interested in reviewing this.

…ix related bug.

bartonjs

Next up: A more comprehensive test that reads and writes COSE public keys (https://tools.ietf.org/html/rfc8152#appendix-C.7.1 has some EC examples; but examples that use the RSA extensions from https://tools.ietf.org/html/rfc8230 are also/likely-more valueable).

To consider:

The addition of the Int32 accelerators has made for some mild asymmetry. Consider adding UInt32 accelerators as well, for symmetry.

New methods are missing negative tests

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborReaderTests.Integer.cs

eiriktsarpalis added the area-System.Security label Apr 9, 2020

eiriktsarpalis added this to the 5.0 milestone Apr 9, 2020

eiriktsarpalis requested a review from bartonjs April 9, 2020 15:30

eiriktsarpalis marked this pull request as draft April 9, 2020 15:30

eiriktsarpalis commented Apr 9, 2020

View reviewed changes

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Tag.cs Outdated Show resolved Hide resolved

eiriktsarpalis commented Apr 9, 2020

View reviewed changes

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Tag.cs Outdated Show resolved Hide resolved

eiriktsarpalis commented Apr 9, 2020

View reviewed changes

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Tag.cs Outdated Show resolved Hide resolved

jaredpar mentioned this pull request Apr 10, 2020

Losing connection to agents during CI / PR #34832

Closed

bartonjs reviewed Apr 13, 2020

View reviewed changes

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborReaderTests.Tag.cs Outdated Show resolved Hide resolved

bartonjs reviewed Apr 13, 2020

View reviewed changes

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Tag.cs Outdated Show resolved Hide resolved

bartonjs reviewed Apr 13, 2020

View reviewed changes

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Tag.cs Outdated Show resolved Hide resolved

bartonjs reviewed Apr 13, 2020

View reviewed changes

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborWriter.Integer.cs Outdated Show resolved Hide resolved

bartonjs reviewed Apr 13, 2020

View reviewed changes

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborWriter.Tag.cs Outdated Show resolved Hide resolved

eiriktsarpalis force-pushed the feature/cbor branch from 21c5907 to 6eafdbc Compare April 14, 2020 14:58

eiriktsarpalis marked this pull request as ready for review April 15, 2020 16:45

eiriktsarpalis commented Apr 15, 2020

View reviewed changes

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.cs Outdated Show resolved Hide resolved

bartonjs reviewed Apr 16, 2020

View reviewed changes

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborReaderTests.Tag.cs Outdated Show resolved Hide resolved

eiriktsarpalis force-pushed the feature/cbor branch from b9e5d06 to db51ff4 Compare April 16, 2020 18:26

bartonjs reviewed Apr 16, 2020

View reviewed changes

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Tag.cs Outdated Show resolved Hide resolved

bartonjs reviewed Apr 16, 2020

View reviewed changes

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Tag.cs Outdated Show resolved Hide resolved

eiriktsarpalis commented Apr 17, 2020

View reviewed changes

jaredpar mentioned this pull request Apr 17, 2020

Hitting restore timeouts with NuGet #35074

Closed

eiriktsarpalis added 6 commits April 20, 2020 13:18

[CBOR] Implement support for dateTime types

72dd7bf

fix test errors

d02f2a6

refine RFC3339 dateTime formatting logic

484feef

add invalid date string tests

d686a8c

Implement BigInteger support

5251fc6

initial decimal support implementation

9943b72

eiriktsarpalis added 16 commits April 20, 2020 13:18

implement checkpointing for tagged type readers

e51fddd

store reader checkpoints in the stack

0d7105b

add tests for rollback logic in tagged type readers

d1a582c

add tested that utilizes nested reader state rollbacks

0c13c32

use culture invariant decimal parsing in tests

261ff0b

add WriteUnixTimeSeconds(double) method

134224b

split unix time and string time readers into separate methods

9033e1c

add WriteUnixTestSeconds invalid input test

3275cfa

add support and tests for indefinite-length buffers in tagged types

2558310

add PeekTag() tests

1f6d5f4

add Read/WriteInt32() convenience methods

db18459

add pervasive buffer postcondition checks on negative reader tests; f…

485a859

…ix related bug.

add comment on DateTime parsing

d550b2a

Rename CborReader.Peek() to CborReader.PeekState()

8b9f7a7

Use correct overload for int32 handling

37cf2bd

add caching to CborReader.PeekState()

69741a8

eiriktsarpalis force-pushed the feature/cbor branch from be9c862 to 69741a8 Compare April 20, 2020 13:40

Use "simple" instead of "special" for cbor major type

26d8198

bartonjs previously approved these changes Apr 20, 2020

View reviewed changes

add Write/ReadUInt32() convenience methods

1533f80

bartonjs reviewed Apr 20, 2020

View reviewed changes

src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborReaderTests.Integer.cs Show resolved Hide resolved

add uint32 negative tests

d33f054

bartonjs approved these changes Apr 20, 2020

View reviewed changes

eiriktsarpalis merged commit 61a8cb1 into dotnet:master Apr 21, 2020

eiriktsarpalis deleted the feature/cbor branch April 21, 2020 09:08

This was referenced Apr 21, 2020

Builds legs getting abandoned due to agent notification issues #35223

Closed

OSX machines are de-provisioned during CI / PR runs leading to failures #34472

Closed

Errors installing the SDK during builds #34015

Closed

ghost locked as resolved and limited conversation to collaborators Dec 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CBOR] Implement support for tagged types #34767

[CBOR] Implement support for tagged types #34767

Uh oh!

eiriktsarpalis commented Apr 9, 2020 •

edited

Loading

Uh oh!

ghost commented Apr 9, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eiriktsarpalis commented Apr 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eiriktsarpalis Apr 17, 2020

Uh oh!

bartonjs left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[CBOR] Implement support for tagged types #34767

[CBOR] Implement support for tagged types #34767

Uh oh!

Conversation

eiriktsarpalis commented Apr 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Apr 9, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eiriktsarpalis commented Apr 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eiriktsarpalis Apr 17, 2020

Choose a reason for hiding this comment

Uh oh!

bartonjs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eiriktsarpalis commented Apr 9, 2020 •

edited

Loading