[mono] Optimize boxing in Pattern Matching idioms#32194
Merged
EgorBo merged 3 commits intodotnet:masterfrom Mar 11, 2020
Merged
[mono] Optimize boxing in Pattern Matching idioms#32194EgorBo merged 3 commits intodotnet:masterfrom
EgorBo merged 3 commits intodotnet:masterfrom
Conversation
lambdageek
reviewed
Feb 12, 2020
Co-Authored-By: Aleksey Kliger (λgeek) <akliger@gmail.com>
BrzVlad
approved these changes
Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes boxing for pattern matching idioms. Basically, it copies existing optimizations from CoreCLR to mono, see impBoxPatternMatch (one of them was recently added by me for coreclr, see #1817)
1)
box + isinst + brtrue/brfalse-->ldc.i4.0/1 + brtrue/brfalse2)
box + isinst + ldnull + ceq/cgt.un-->ldc.i4.0/13)
box + isinst + unbox.any-->nopTests can be found here: https://github.com/dotnet/runtime/tree/master/src/coreclr/tests/src/JIT/Generics/Conversions/Boxing
Sharplab.io link to observe IL code for the samples above.
Codegen diff example:
Before (for
Test):After: