Repository navigation
[cDAC] Fix stale contract docs and README - #135472
Merged
Merged
Conversation
Each fix was checked against the current source: - Exception.md: ExceptionInfo::ThrownObject is ExInfo::m_exception, an object reference, not a handle. GetNestedExceptionInfo returns the field's address as the pseudo-handle and its value as the object (Exception_1.cs). The descriptor meaning is corrected and the generated tables in Exception.md, Thread.md and WindowsErrorReporting.md are regenerated. - Thread.md: GetThreadData read a FeatureEHFunclets global that was removed in dotnet#116743; Thread::ExceptionTracker is always read through. - ReJIT.md: GetRejitIds is the IReJITExtensions extension method, not a contract API, and like ReJitManager::GetReJITIDs it only counts versions whose source is ReJIT. - cdac README: a Debug runtime is not required for the legacy DAC to delegate to the cDAC (CAN_USE_CDAC depends only on USE_DAC_TABLE_RVA), and runtime-diagnostics runs SOS.Tests on all seven sosPlatforms, not only Windows x64.
|
Azure Pipelines: Successfully started running 2 pipeline(s). 14 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
dotnet-policy-service
Bot
added
the
community-contribution
rcj1
reviewed
Oct 9, 2026
Review feedback: that GetRejitIds is implemented as an extension method is an implementation detail the contract doc does not need to expose. Restore it to the API list with its original signature, and keep only the corrected pseudo-code: like ReJitManager::GetReJITIDs, it counts only versions whose source is ReJIT.
jkotas
reviewed
Oct 9, 2026
jkotas
reviewed
Oct 9, 2026
Wrap the runtime-configuration paragraph to the file's line width, and say that the `#if DEBUG` cross-validation still needs a legacy DAC that matches the runtime build.
rcj1
approved these changes
Oct 12, 2026
Contributor
|
/ba-g unrelated fail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each item was checked against the current source.
Exception.md. TheGetNestedExceptionInfopseudo-code dereferencesExceptionInfo::ThrownObjectas a handle. The field isExInfo::m_exception, anOBJECTREF. The implementation returns the field's address as the pseudo-handle and its value as the object (Exception_1.cs). The descriptor meaning said "Handle to the thrown exception object". It is corrected, and the generated tables inException.md,Thread.mdandWindowsErrorReporting.mdare regenerated withCdacUsageGraph docs.Thread.md.GetThreadDatastill reads theFeatureEHFuncletsglobal, which [cDAC] Remove references to FEATURE_EH_FUNCLETS #116743 removed.Thread_1always reads throughThread::ExceptionTracker.ReJIT.md. TheGetRejitIdspseudo-code drops theSource == ReJITcheck that both the cDAC implementation andReJitManager::GetReJITIDsapply.README.md.CAN_USE_CDACdepends only onUSE_DAC_TABLE_RVA, and the Release-runtime SOS legs run the cDAC configurations. The#if DEBUGcross-validation still needs a legacy DAC that matches the runtime build, and the README now says so.runtime-diagnostics.ymlruns them on all sevensosPlatforms.CdacUsageGraph docs --checkand Usage.Tests pass.Note
This PR was prepared with AI assistance (Anthropic Claude, reviewed with OpenAI Codex). Each claim was checked against the source locally.