Repository navigation
[cDAC] Test entry-point MethodDesc resolution - #135470
Merged
Merged
Conversation
Follow-up to dotnet#135450. The non-portable paths of NonVirtualEntry2MethodDesc, which every populated vtable slot now goes through, and the temporary-entry-point check in ValidateMethodDescPointer had no unit coverage. - ExecutionManagerTests: NonVirtualEntry2MethodDesc for jitted code, for a FIXUPPRECODE range list, for a range-list address that is not a precode (null), and for an address in no range section (null, never decoded). - MethodDescTests: GetMethodDescForSlot resolves a populated vtable slot through NonVirtualEntry2MethodDesc, and ValidateMethodDescPointer requires the temporary entry point to resolve back to the MethodDesc, through the precode when PrecodeStubs is advertised and through NonVirtualEntry2MethodDesc otherwise. - MockDescriptors: AddMethodTableWithVtable (one vtable indirection and its slots).
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
/ba-g unrelated stress fails |
rcj1
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #135450. Every populated vtable slot now resolves through
NonVirtualEntry2MethodDesc, but its non-portable paths had no unit coverage. Neither did the temporary-entry-point check inValidateMethodDescPointer. Before this change, breaking any of the following still passed every test:GetMethodDescForSlot;Tests added:
ExecutionManagerTests:NonVirtualEntry2MethodDescforFIXUPPRECODErange list;MethodDescTests:GetMethodDescForSlotresolving a populated vtable slot;ValidateMethodDescPointerrequiring the temporary entry point to resolve back to the MethodDesc, over portable × resolves-to-self.MockDescriptors:AddMethodTableWithVtable.With these tests, each of 12 single-guard mutations fails, and each fails in one test method:
NonVirtualEntry2MethodDescbranch;ValidateForDataAccessguards.UnitTests: 3324/3324 pass on linux-x64, osx-arm64 and windows-x64. On osx-arm64 and windows-x64 the mutation that makes
NonVirtualEntry2MethodDescreturn null for a precode address was also re-run, and its test fails on both.Note
This PR was prepared with AI assistance (Anthropic Claude, reviewed with OpenAI Codex). The tests and the mutation runs were executed locally.