Repository navigation
Acquire type-loading completion flags in MethodTable and TypeDesc - #135180
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix concurrent generic type loading issue on Arm64
Acquire type-loading completion flags in MethodTable and TypeDesc
Oct 4, 2026
jkotas
reviewed
Oct 4, 2026
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The low-level concurrency fix appears sound but lacks targeted validation on weakly ordered architectures.
Review effort: Balanced
Findings: None
What changed in this PR
Adds acquire semantics to CoreCLR type-loading completion checks, preventing stale payload reads on weakly ordered architectures.
Changes:
- Uses
VolatileLoadforMethodTablereadiness flags. - Applies equivalent semantics to
TypeDesc. - Reuses one acquired snapshot per load-level query.
| File | Description |
|---|---|
src/coreclr/vm/methodtable.h |
Acquires MethodTable loading flags. |
src/coreclr/vm/typedesc.h |
Acquires fully-loaded state. |
src/coreclr/vm/typedesc.cpp |
Acquires one load-level snapshot. |
davidwrighton
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain readiness reads can observe completed type loading before its payload writes on Arm64, allowing a child type to retain null inherited dictionary pointers.
VolatileLoadforGetLoadLevel,IsFullyLoaded, andHasApproxParent.GetLoadLevelandIsFullyLoaded, with one flags read per load-level query.