Skip to content

Add FTPS directory listing regression test - #135077

Merged
wfurt merged 1 commit into
dotnet:mainfrom
wfurt:wfurt/ftp-list-directory-details-test
Oct 3, 2026
Merged

wfurt merged 1 commit into
dotnet:mainfrom
wfurt:wfurt/ftp-list-directory-details-test

Conversation

@wfurt

@wfurt wfurt commented Oct 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Add enterprise coverage for synchronous FtpWebRequest ListDirectoryDetails requests with and without TLS.
  • Verify that the returned listing is plaintext, contains the uploaded fixture, and completes with FtpStatusCode.ClosingData.
  • Clean up the uploaded fixture even when the listing assertion fails.
  • Document the additional FTPS directory-listing coverage.

This directly covers the scenario reported in #134130. The product fix is already present on main via #123234; this PR adds coverage for the specific listing operation from the newer report.

Testing

  • ./build.sh clr+libs -rc release in the Linux enterprise test client: succeeded with 0 warnings and 0 errors.
  • /repo/dotnet.sh build /t:Test /p:XunitMethodName=System.Net.Tests.FtpWebRequestStreamDisposalTest.FtpListDirectoryDetails_ReturnsPlainText: 2 passed, 0 failed, 0 skipped.
  • Negative control: temporarily restored the old synchronous stream-selection expression and rebuilt System.Net.Requests; the non-TLS case passed while the TLS case failed in StreamReader.ReadToEnd with ObjectDisposedException.
  • The attached issue repro's request sequence was also verified against controlled ProFTPD: .NET 10.0.0 returned TLS ciphertext despite status 226, while .NET 11 RC1 returned the expected plaintext listing.

Note

This pull request description was generated with GitHub Copilot.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @karelz, @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@wfurt
wfurt merged commit e0bb657 into dotnet:main Oct 3, 2026
86 of 88 checks passed
@wfurt
wfurt deleted the wfurt/ftp-list-directory-details-test branch October 3, 2026 04:29
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants