Arm64-SVE: Fixes for returning Vector<T> through the return buffer - #131746
Arm64-SVE: Fixes for returning Vector<T> through the return buffer#131746snickolls-arm wants to merge 3 commits into
Conversation
Invalidates debug information for return buffer when it holds TYP_SIMD. Computing an accurate stack offset is not possible in AOT, so we avoid introducing this support. Better information can be provided when the return value is passed in a vector register. Prevent the hidden return buffer optimization when the local has TYP_SIMD. This optimization will no longer apply when the full vector calling convention is supported, so we avoid building support now.
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
@dotnet/arm64-contrib Please could I have a review for this patch? |
What support is that? It is not clear to me if this isn't just hiding some bug that should be addresses regardless. |
|
Is it just about the |
Yes, the assertion in |
Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
Invalidates debug information for return buffer when it holds TYP_SIMD. Computing an accurate stack offset is not possible in AOT, so we avoid introducing this support. Better information can be provided when the return value is passed in a vector register.
Prevent the hidden return buffer optimization when the local has TYP_SIMD. This optimization will no longer apply when the full vector calling convention is supported, so we avoid building support now.