Skip to content

Align NativeAOT array element size limit #130019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichalStrehovsky merged 3 commits into from
Jul 1, 2026
+33 −1
Merged

Align NativeAOT array element size limit #130019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c820f6
Initial plan
Copilot Jun 30, 2026
2a0c8a8
Fix NativeAOT max array element size validation
Copilot Jun 30, 2026
ccaaf84
Remove IlcCompile item group from project file
MichalStrehovsky Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/tools/Common/Compiler/CompilerTypeSystemContext.Validation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ private static TypeDesc EnsureLoadableTypeUncached(TypeDesc type)
if (parameterizedType.IsArray)
{
LayoutInt elementSize = parameterType.GetElementSize();
if (!elementSize.IsIndeterminate && elementSize.AsInt >= ushort.MaxValue)
if (!elementSize.IsIndeterminate && elementSize.AsInt > ushort.MaxValue)
{
// Element size over 64k can't be encoded in the GCDesc
ThrowHelper.ThrowTypeLoadException(ExceptionStringID.ClassLoadValueClassTooLarge, parameterType);
Expand Down
24 changes: 24 additions & 0 deletions src/tests/Loader/classloader/InlineArray/MaxArrayElementSize.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Runtime.CompilerServices;
using Xunit;

public unsafe class MaxArrayElementSize
{
[InlineArray(65535)]
struct MaxSizedArrayElement
{
byte b;
}

[Fact]
public static int TestEntryPoint()
{
return sizeof(MaxSizedArrayElement) == ushort.MaxValue
&& new MaxSizedArrayElement[1].Length == 1
? 100
: 101;
}
}
8 changes: 8 additions & 0 deletions src/tests/Loader/classloader/InlineArray/MaxArrayElementSize.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>
<ItemGroup>
<Compile Include="MaxArrayElementSize.cs" />
</ItemGroup>
</Project>
Loading