Add AssemblyLoadContext.SetAssemblyLocationOverride#129773
Open
cdmazom wants to merge 6 commits into
Open
Conversation
Adds a static, set-once callback that overrides the value returned by Assembly.Location. The callback is stored in the shared AssemblyLoadContext and applied by RuntimeAssembly.Location on CoreCLR, Mono, and NativeAOT. Updates the System.Runtime.Loader reference assembly and adds tests covering the override, the set-once guard, and null handling. Fix dotnet#127097
cdmazom
requested review from
MichalStrehovsky,
steveisok and
vitek-karas
as code owners
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/area-system-reflection |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new public API, AssemblyLoadContext.SetAssemblyLocationOverride, which allows a process-wide, set-once callback to override the value returned by Assembly.Location. The override is applied consistently across CoreCLR, Mono, and NativeAOT by routing each runtime’s RuntimeAssembly.Location implementation through a shared resolver in AssemblyLoadContext.
Changes:
- Adds
AssemblyLoadContext.SetAssemblyLocationOverride(Func<Assembly, string, string>)and an internalResolveAssemblyLocationhelper inSystem.Private.CoreLib. - Updates CoreCLR/Mono/NativeAOT
Assembly.Locationimplementations to apply the override. - Updates the System.Runtime.Loader reference assembly and adds tests for null argument, override behavior, and set-once enforcement.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Private.CoreLib/src/System/Runtime/Loader/AssemblyLoadContext.cs | Adds the set-once callback storage, public setter API, and internal location resolver used by all runtimes. |
| src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs | Applies the location override when returning Assembly.Location on CoreCLR. |
| src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs | Applies the location override when returning Assembly.Location on Mono. |
| src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/Runtime/General/ThunkedApis.cs | Applies the location override when returning Assembly.Location on NativeAOT. |
| src/libraries/System.Runtime.Loader/ref/System.Runtime.Loader.cs | Adds the new public API to the reference assembly surface. |
| src/libraries/System.Runtime.Loader/tests/AssemblyLoadContextTest.cs | Adds tests for null argument, stream-loaded override behavior, and set-once guard (RemoteExecutor isolation). |
| src/libraries/System.Private.CoreLib/src/Resources/Strings.resx | Adds SR string for the “already set” exception message. |
Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
Member
|
Could you please sign the Contributor License Agreement? This is good to go otherwise. |
jkotas
reviewed
Jun 25, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
3 tasks
Author
Just awaiting confirmation from our legal dept. |
Author
|
@dotnet-policy-service agree company="Unity Technologies SF" |
Member
|
@elinor-fung Could you please review and merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a static, set-once callback that overrides the value returned by Assembly.Location. The callback is stored in the shared AssemblyLoadContext and applied by RuntimeAssembly.Location on CoreCLR, Mono, and NativeAOT.
Updates the System.Runtime.Loader reference assembly and adds tests covering the override, the set-once guard, and null handling.
Fix #127097