Skip to content

[RyuJit/WASM] Remove the special prolog handling#128721

Merged
AndyAyersMS merged 2 commits into
dotnet:mainfrom
SingleAccretion:Emit-PrologIG-Exec
Jul 2, 2026
Merged

[RyuJit/WASM] Remove the special prolog handling#128721
AndyAyersMS merged 2 commits into
dotnet:mainfrom
SingleAccretion:Emit-PrologIG-Exec

Conversation

@SingleAccretion

@SingleAccretion SingleAccretion commented May 28, 2026

Copy link
Copy Markdown
Contributor

Fixes #125200.

@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 28, 2026
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label May 28, 2026
@SingleAccretion SingleAccretion force-pushed the Emit-PrologIG-Exec branch 2 times, most recently from 4db2687 to 1714150 Compare May 28, 2026 20:07
@build-analysis build-analysis Bot mentioned this pull request May 29, 2026
Open
3 tasks
@JulieLeeMSFT JulieLeeMSFT added this to the 11.0.0 milestone May 29, 2026
This was referenced May 29, 2026
Open
Open
Open
@build-analysis build-analysis Bot mentioned this pull request May 30, 2026
Open
3 tasks
@build-analysis build-analysis Bot mentioned this pull request Jun 11, 2026
Closed
@AndyAyersMS

AndyAyersMS commented Jun 24, 2026

Copy link
Copy Markdown
Member

@SingleAccretion do you plan to keep working on this?

@SingleAccretion

SingleAccretion commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

do you plan to keep working on this?

This is basically ready, let's bounce the CI one more time before review...

@build-analysis build-analysis Bot mentioned this pull request Jun 24, 2026
Open
3 tasks
@SingleAccretion SingleAccretion marked this pull request as ready for review June 25, 2026 12:05
@SingleAccretion

SingleAccretion commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@dotnet/jit-contrib

@build-analysis build-analysis Bot mentioned this pull request Jun 25, 2026
Open
AndyAyersMS
AndyAyersMS approved these changes Jun 27, 2026
View reviewed changes

@AndyAyersMS AndyAyersMS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamperlin can you do a secondary review.

@AndyAyersMS AndyAyersMS requested a review from adamperlin June 27, 2026 01:40
@AndyAyersMS

AndyAyersMS commented Jul 1, 2026

Copy link
Copy Markdown
Member

@adamperlin ping

adamperlin
adamperlin approved these changes Jul 1, 2026
View reviewed changes

@adamperlin adamperlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, I just had a question about the initialization of emitCurIG.

Comment thread src/coreclr/jit/emit.h
@am11 am11 added the arch-wasm WebAssembly architecture label Jul 1, 2026
@dotnet-policy-service

dotnet-policy-service Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS AndyAyersMS merged commit 0d72d09 into dotnet:main Jul 2, 2026
156 of 161 checks passed
@AndyAyersMS

AndyAyersMS commented Jul 2, 2026

Copy link
Copy Markdown
Member

Thanks again, @SingleAccretion!

This was referenced Jul 2, 2026
Open
Open
@AaronRobinsonMSFT

AaronRobinsonMSFT commented Jul 2, 2026

Copy link
Copy Markdown
Member

I'm seeing the following failure. Was this missed in this PR?

  .../runtime/src/coreclr/jit/codegenwasm.cpp:363:24: error: no member named 'compGeneratingProlog' in 'Compiler'
    363 |     assert(m_compiler->compGeneratingProlog);
        |            ~~~~~~~~~~  ^
  1 error generated.

@pavelsavara

pavelsavara commented Jul 2, 2026

Copy link
Copy Markdown
Member

I'm seeing the following failure. Was this missed in this PR?

I see the same

@AndyAyersMS

AndyAyersMS commented Jul 2, 2026

Copy link
Copy Markdown
Member

#130131 has a fix.

It was an older PR and some new instance got introduced.

@jkotas

jkotas commented Jul 2, 2026

Copy link
Copy Markdown
Member

This also introduced build break in Build linux-riscv64 Debug CoreCLR_Bootstrapped. I do not see the failure in other PRs merged before this one: #130145

This was referenced Jul 2, 2026
Closed
Closed
@dotnet-maestro dotnet-maestro Bot mentioned this pull request Jul 3, 2026
Merged
@dotnet-milestone-bot dotnet-milestone-bot Bot modified the milestones: 11.0.0, 11.0-preview7 Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes
@adamperlin adamperlin adamperlin approved these changes

Assignees

@SingleAccretion SingleAccretion

Labels

arch-wasm WebAssembly architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

[Wasm RyuJit] prolog IG can overflow

8 participants

@SingleAccretion @AndyAyersMS @AaronRobinsonMSFT @pavelsavara @jkotas @adamperlin @am11 @JulieLeeMSFT