Skip to content

[clr-ios] Enable Debug CoreCLR Apple Mobile jobs in extra-platforms pipelines#127498

Draft
Copilot wants to merge 7 commits into
mainfrom
copilot/enable-debug-jobs-coreclr
Draft

[clr-ios] Enable Debug CoreCLR Apple Mobile jobs in extra-platforms pipelines#127498
Copilot wants to merge 7 commits into
mainfrom
copilot/enable-debug-jobs-coreclr

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 28, 2026 •
edited by kotlarmilos
Loading

Description

Enables the previously commented-out Debug CoreCLR libraries smoke test jobs for tvos_arm64, iossimulator_arm64, and maccatalyst_arm64.

Copilot AI and others added 3 commits April 27, 2026 14:42
@kotlarmilos
Enable Debug CoreCLR Apple Mobile jobs and increase Helix job timeout
6ff6283 
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/c32dcf35-28d9-4beb-8c18-942eb71c4220

Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>
@kotlarmilos
Revert timeoutInMinutes to 240; bump Helix _workItemTimeout to 02:00:…
454ba31 
…00 for Debug jobs

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/8cf56017-6b35-4fc5-8a11-356fe45c767b

Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>
@kotlarmilos
Remove /p:_workItemTimeout=02:00:00 from extraHelixArguments
4021644 
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/8a454479-8b1b-4f83-8e7d-21efb35e1996

Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>
Copilot AI self-assigned this Apr 28, 2026
Copilot AI review requested due to automatic review settings April 28, 2026 09:50
Copilot AI review requested due to automatic review settings April 28, 2026 09:50
@kotlarmilos kotlarmilos added area-Infrastructure-coreclr Only use for closed issues os-ios Apple iOS labels Apr 28, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

dotnet-policy-service Bot commented Apr 28, 2026

Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

@kotlarmilos
Copy link
Copy Markdown
Member

kotlarmilos commented Apr 28, 2026

/azp run runtime-extra-platforms

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Apr 28, 2026

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 28, 2026
Open
Open
Open
Closed
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

🤖 Copilot Code Review — PR #127498

Note

This review was generated by GitHub Copilot.

Holistic Assessment

Motivation: The PR re-enables Debug CoreCLR Apple Mobile CI jobs (tvOS, iOSSimulator, MacCatalyst) that were previously disabled and tracked in issue #124344. Expanding CI coverage to Debug configurations is valuable for catching debug-only assertions and issues on these platforms.

Approach: The approach is correct — simply uncommenting the existing job definitions that were disabled. The final job configuration matches the established patterns of sibling Release jobs. The iterative commits show timeout adjustments were explored and reverted to match existing conventions (240 min timeoutInMinutes, no custom _workItemTimeout).

Summary: ✅ LGTM. The change is a clean, mechanical uncomment of previously-disabled CI jobs. The final configuration is consistent with existing sibling jobs in all three pipeline files.

Detailed Findings

✅ Correctness — Job definitions match existing patterns

The newly enabled Debug jobs are structurally identical to the Release counterparts in the same files:

  • Same platform-matrix.yml template usage
  • Same helixQueuesTemplate (/eng/pipelines/libraries/helix-queues-setup.yml)
  • Same variables block with librariesContainsChange, coreclrContainsChange, illinkContainsChange
  • Same buildArgs pattern (-s clr+clr.runtime+libs+packs+libs.tests with appropriate flags)
  • Same timeoutInMinutes: 240 (consistent with Release counterparts)
  • Same extraHelixArguments: /p:NeedsToBuildAppsOnHelix=true

The only difference is buildConfig: Debug (vs Release) and nameSuffix including _Smoke/_Smoke_Debug to differentiate job names — this is correct.

✅ Consistency — All three files updated uniformly

All three pipeline files (ioslike, ioslikesimulator, maccatalyst) received the same treatment, ensuring coverage parity across Apple mobile platforms.

✅ Cleanup — Tracking issue reference removed

The # Tracked in https://github.com/dotnet/runtime/issues/124344 comments were correctly removed since the jobs are no longer disabled.

💡 Commit history — Iterative refinement

The PR shows three commits iterating on timeout configuration before settling on the standard timeoutInMinutes: 240 with no custom _workItemTimeout. The final state is clean and consistent. Consider squashing before merge for a cleaner history.

Generated by Code Review for issue #127498 · ◷

@kotlarmilos
Copy link
Copy Markdown
Member

kotlarmilos commented Apr 30, 2026

/azp run runtime-extra-platforms

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Apr 30, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis Bot mentioned this pull request Apr 30, 2026
Open
@kotlarmilos kotlarmilos mentioned this pull request Apr 30, 2026
Open
15 tasks
This was referenced Apr 30, 2026
Open
Open
Open
Open
Open
@kotlarmilos kotlarmilos changed the title Enable Debug CoreCLR Apple Mobile jobs in extra-platforms pipelines [clr-ios] Enable Debug CoreCLR Apple Mobile jobs in extra-platforms pipelines May 4, 2026
@kotlarmilos
Copy link
Copy Markdown
Member

kotlarmilos commented May 4, 2026

/azp run runtime-extra-platforms

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented May 4, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis Bot mentioned this pull request May 5, 2026
Open
Copilot AI review requested due to automatic review settings May 15, 2026 11:33
Copilot AI reviewed May 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 3

Comment thread eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml Outdated
Comment thread eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml Outdated
Comment thread eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.yml Outdated
@kotlarmilos
Force RunSmokeTestsOnly=true for Debug CoreCLR Apple-mobile smoke jobs
b2d5982 
In runtime-extra-platforms / runtime-{ioslike,ioslikesimulator,maccatalyst}
pipelines, isRunSmokeTestsOnly is false (eng/pipelines/common/variables.yml),
so $(_runSmokeTestsOnlyArg) expands to /p:RunSmokeTestsOnly=false and the
"_Smoke" jobs would actually run the full libraries matrix. Hardcode
/p:RunSmokeTestsOnly=true to match the convention in eng/pipelines/runtime.yml
and keep the job duration manageable.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kotlarmilos
Copy link
Copy Markdown
Member

kotlarmilos commented May 15, 2026

/azp run runtime-extra-platforms

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented May 15, 2026

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 16, 2026
Open
Open
Open
Open
Open
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@kotlarmilos kotlarmilos

Copilot code review Copilot

Labels

area-Infrastructure-coreclr Only use for closed issues os-ios Apple iOS

Projects

Runtime Infra
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos