Update devcontainer Dockerfile - #127460
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/e01dfde2-e3fd-478e-aa3c-c270ffb6f75b Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix package mismatch between Dockerfile and requirements documentation
Sync Linux devcontainer package requirements
Apr 27, 2026
am11
reviewed
Apr 27, 2026
Contributor
|
Tagging subscribers to this area: @dotnet/area-meta |
vcsjones
reviewed
Apr 28, 2026
jkotas
reviewed
Apr 28, 2026
jtschuster
changed the title
jtschuster
changed the title
am11
reviewed
Apr 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the devcontainer Dockerfile to install build prerequisites by downloading and running the repo’s eng/common/native/install-dependencies.sh script during image creation, instead of maintaining a hardcoded apt-get install list.
Changes:
- Switches the devcontainer base image variant default from
8.0-nobleto10.0-noble. - Replaces the explicit
apt-get installdependency list with acurl+bash install-dependencies.shstep. - Adds a note intending to keep dependencies aligned with the documented Linux requirements.
am11
reviewed
Apr 28, 2026
am11
reviewed
Apr 28, 2026
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
For now maybe we can just use the install-dependencies.sh script for dev containers / Codespaces to enable building runtime without installing additional packages. |
jtschuster
marked this pull request as ready for review
May 5, 2026 10:52
Member
I agree that this is good enough for standard configuration. Those additional packages are not required to build / debug runtime. User is free to install any other package in dev containers. |
jkotas
approved these changes
May 6, 2026
jakobbotsch
pushed a commit
to jakobbotsch/runtime
that referenced
this pull request
May 12, 2026
The devcontainer package list was missing some requirements to build, so new codespaces could not build runtime. Update the Dockerfile to curl and run the install-dependencies script during creation to install the packages. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com> Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The devcontainer package list was missing some requirements to build, so new codespaces could not build runtime. Update the Dockerfile to curl and run the install-dependencies script during creation to install the packages.