-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Support typeof(T).Assembly.GetType(string) in ILLink dataflow analysis #127319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MichalStrehovsky
merged 8 commits into
dotnet:main
from
MichalStrehovsky:assembly-gettype-dataflow
May 9, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4d5cb42
Support typeof(T).Assembly.GetType(string) in ILLink dataflow analysis
MichalStrehovsky dd1c802
Address review feedback: new IL2128 diagnostic, fix Type_get_Assembly…
MichalStrehovsky 605742c
Add test for unknown type's assembly in GetType
MichalStrehovsky 42dd2a0
Fall back to RUC warning when Assembly.GetType cannot be analyzed
MichalStrehovsky 2be7945
Unify TypeNameResolver to handle Assembly.GetType semantics
MichalStrehovsky c1a65d9
Reject non-named types from Type.Assembly dataflow
MichalStrehovsky 4a029f0
Reject top-level assembly-qualified names in Assembly.GetType analysis
MichalStrehovsky b6ac7c0
Restore Type_get_Assembly IsEmpty short-circuit
MichalStrehovsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
src/tools/illink/src/ILLink.Shared/TrimAnalysis/AssemblyValue.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // Copyright (c) .NET Foundation and contributors. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| using ILLink.Shared.DataFlow; | ||
|
|
||
| // This is needed due to NativeAOT which doesn't enable nullable globally yet | ||
| #nullable enable | ||
|
|
||
| namespace ILLink.Shared.TrimAnalysis | ||
| { | ||
| /// <summary> | ||
| /// A known Assembly value, represented by its simple name. | ||
| /// For example, the result of typeof(SomeType).Assembly. | ||
| /// </summary> | ||
| internal sealed record AssemblyValue : SingleValue | ||
| { | ||
| public AssemblyValue(string assemblyName) => AssemblyName = assemblyName; | ||
|
|
||
| public readonly string AssemblyName; | ||
|
|
||
| public override SingleValue DeepCopy() => this; // This value is immutable | ||
|
|
||
| public override string ToString() => this.ValueToString(AssemblyName); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.