Rename JitDasmWithAddress to JitDisasmWithAddress#127267
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a084cf27-a4f9-4c4d-9f76-e1e298958f3f Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jakobbotsch
April 22, 2026 08:46
View session
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Apr 22, 2026
Open
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the JIT config option/accessor from JitDasmWithAddress to JitDisasmWithAddress, including updating the underlying config key string.
Changes:
- Rename config entry in
jitconfigvalues.htoJitDisasmWithAddress(accessor + key string). - Update
compiler.cppto read the newJitConfig.JitDisasmWithAddress()accessor.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/coreclr/jit/jitconfigvalues.h |
Renames the config entry and updates the key string to match JitDisasm* naming. |
src/coreclr/jit/compiler.cpp |
Switches the option check to the renamed config accessor. |
Member
|
PTAL @dotnet/jit-contrib Simple change to make this environment variable consistent with other ones. |
tannergooding
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JitDasmWithAddresstoJitDisasmWithAddressJitDisasmWithAddressValidation
./build.sh clr+libs+host(baseline, before changes)./build.sh clrparallel_validation(Code Review: no comments, CodeQL: no alerts)