Fix type formatting in logging source generator test#124962
Open
svick wants to merge 1 commit intodotnet:mainfrom
Open
Fix type formatting in logging source generator test#124962svick wants to merge 1 commit intodotnet:mainfrom
svick wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-logging |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates a logging source generator baseline to match the generator’s current type-display formatting after prior related changes (generic method support + type formatting adjustments), ensuring the test suite reflects actual generated output.
Changes:
- Adjusted the
TestWithRefReadOnlyParambaseline to use C# keywordintinstead ofglobal::System.Int32in generated signatures andLoggerMessage.Define<>calls.
akoeplinger
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happened because I didn't test #124638 and #124589 together (they contained changes that influenced each other).
This fixes the CI failure mentioned in #124957 (comment).
cc: @akoeplinger