Don't build managed ilasm in the VMR yet#124762
Merged
jkoritzinsky merged 2 commits intomainfrom Feb 23, 2026
Merged
Conversation
We aren't ready to build it in source-build scenarios (need SB-externals work and some local dependency changes too) and it's not shipping anyway at the moment.
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR conditionally excludes the managed ilasm tool from VMR (Virtual Monolithic Repository) builds while retaining it for standard dotnet/runtime builds. The change addresses build dependencies that aren't ready for source-build scenarios yet.
Changes:
- Added a condition to skip building the managed ilasm tool (
$(ToolsProjectRoot)ilasm\src\ilasm\ilasm.csproj) when building from the VMR (DotNetBuildFromVMR== 'true')
akoeplinger
approved these changes
Feb 23, 2026
kg
reviewed
Feb 23, 2026
kg
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We aren't ready to build it in source-build scenarios (need SB-externals work and some local dependency changes too) and it's not shipping anyway at the moment.