Skip to content

Comments

Don't build managed ilasm in the VMR yet#124762

Merged
jkoritzinsky merged 2 commits intomainfrom
jkoritzinsky-patch-1
Feb 23, 2026
Merged

Don't build managed ilasm in the VMR yet#124762
jkoritzinsky merged 2 commits intomainfrom
jkoritzinsky-patch-1

Conversation

@jkoritzinsky
Copy link
Member

We aren't ready to build it in source-build scenarios (need SB-externals work and some local dependency changes too) and it's not shipping anyway at the moment.

We aren't ready to build it in source-build scenarios (need SB-externals work and some local dependency changes too) and it's not shipping anyway at the moment.
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR conditionally excludes the managed ilasm tool from VMR (Virtual Monolithic Repository) builds while retaining it for standard dotnet/runtime builds. The change addresses build dependencies that aren't ready for source-build scenarios yet.

Changes:

  • Added a condition to skip building the managed ilasm tool ($(ToolsProjectRoot)ilasm\src\ilasm\ilasm.csproj) when building from the VMR (DotNetBuildFromVMR == 'true')

Copilot AI review requested due to automatic review settings February 23, 2026 20:29
@jkoritzinsky jkoritzinsky enabled auto-merge (squash) February 23, 2026 20:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants