Remove duplicate typeof(decimal) check in IsKnownComparable<T>#124737
Merged
stephentoub merged 1 commit intodotnet:mainfrom Feb 23, 2026
Merged
Remove duplicate typeof(decimal) check in IsKnownComparable<T>#124737stephentoub merged 1 commit intodotnet:mainfrom
stephentoub merged 1 commit intodotnet:mainfrom
Conversation
In Constants.IsKnownComparable<T>(), the condition `typeof(T) == typeof(decimal)` appeared twice. Therefore, I have removed the duplicated check.
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-collections |
stephentoub
approved these changes
Feb 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a redundant typeof(T) == typeof(decimal) clause from Constants.IsKnownComparable<T>() in System.Collections.Frozen, keeping the method’s known-comparable whitelist functionally identical while avoiding duplicate logic.
Changes:
- Removed the duplicated
typeof(T) == typeof(decimal)check inConstants.IsKnownComparable<T>().
Contributor
|
Maybe worth to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
Constants.IsKnownComparable<T>(), the conditiontypeof(T) == typeof(decimal)appeared twice.Therefore, I have removed the duplicated check.