[RyuJit/WASM] Rewrite SP references into PHYSREGs#124710
Merged
AndyAyersMS merged 1 commit intodotnet:mainfrom Feb 22, 2026
Merged
[RyuJit/WASM] Rewrite SP references into PHYSREGs#124710AndyAyersMS merged 1 commit intodotnet:mainfrom
AndyAyersMS merged 1 commit intodotnet:mainfrom
Conversation
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
SingleAccretion
force-pushed
the
WasmJit-SP
branch
from
8f23e14 to
8b488fe
Compare
The special SP local presents unique challenges for RA: 1) It can't be a proper candidate since it lacks correct liveness due to implicit uses. 2) Even if we change liveness, we don't want to allocate it to stack even in debug mode. Both because it is wasteful and because it makes the contract for opcodes like LCLHEAP more complicated. The solution implemented here is to treat the SP specially in RA: 1) Neuter its local to make it look as if it has no references. That makes sure we don't spill it to stack in debug code and straightens out the contract with codegen w.r.t. candidate liveness. 2) Rewrite all explicit references into PHYSREG nodes. In effect, we transfer the 'ownership' of the SP value from the local to the "SP reg" well-known codegen location, confining all the "specialness" to RA.
SingleAccretion
force-pushed
the
WasmJit-SP
branch
from
8b488fe to
01a72d9
Compare
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Contributor
Author
|
@dotnet/jit-contrib |
AndyAyersMS
approved these changes
Feb 22, 2026
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The special SP local presents unique challenges for RA:
The solution implemented here is to treat the SP specially in RA:
In effect, we transfer the 'ownership' of the SP value from the local to the "SP reg" well-known codegen location, confining all the "specialness" to RA.