[HTTP] Re-enable GetAsync_UnicodeHostName_SuccessStatusCodeInResponse test#124596
Merged
ManickaP merged 2 commits intodotnet:mainfrom Feb 23, 2026
Merged
Conversation
The external Korean Starbucks website (스타벅스코리아.com / xn--oy2b35ckwhba574atvuzkc.com) that was unreachable in 2019 is now accessible again. Remove the ActiveIssue attribute to re-enable the test, keeping the original test logic that exercises the full Unicode hostname to punycode IDN conversion path. Fixes dotnet#29424 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request re-enables the GetAsync_UnicodeHostName_SuccessStatusCodeInResponse test that was disabled in 2019 due to an unreachable external Korean Starbucks website. The site (스타벅스코리아.com / xn--oy2b35ckwhba574atvuzkc.com) is now accessible again, allowing the test to exercise Unicode hostname to punycode IDN conversion. The test is re-enabled with an HTTP/3 exclusion since the site doesn't support that protocol.
Changes:
- Removed the
[ActiveIssue]attribute to re-enable the test - Added an HTTP/3 version check to skip the test when using HTTP/3, with explanatory comment
rzikm
approved these changes
Feb 19, 2026
MihaZupan
approved these changes
Feb 19, 2026
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
I'm getting: Maybe we should delete this test as well. Until we have full control over the target, we'll never have stability. |
The external Korean Starbucks website used by this test is unreliable, making it unsuitable for CI. Delete the test entirely rather than keeping it disabled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The external Korean Starbucks website (스타벅스코리아.com / xn--oy2b35ckwhba574atvuzkc.com) that was unreachable in 2019 is now accessible again. Remove theActiveIssueattribute to re-enable the test, keeping the original test logic that exercises the full Unicode hostname to punycode IDN conversion path.Excludes H/3 as the site doesn't support it.The test is removed, the target is unreliable.
Fixes #29424