Skip to content

Comments

Publish Uri and UriBuilder threat models#124273

Merged
MihaZupan merged 4 commits intomainfrom
mizupan/uri-threatmodels
Feb 24, 2026
Merged

Publish Uri and UriBuilder threat models#124273
MihaZupan merged 4 commits intomainfrom
mizupan/uri-threatmodels

Conversation

@MihaZupan
Copy link
Member

These are a mix of threat model / implementation design doc.

I'll link to this from public docs once it's merged.
The Fuzzing section refers to a non-existent file for now since I'm waiting on #123932 to get merged first.

@MihaZupan MihaZupan added this to the 11.0.0 milestone Feb 11, 2026
@MihaZupan MihaZupan requested review from a team, GrabYourPitchforks and blowdart February 11, 2026 14:12
@MihaZupan MihaZupan self-assigned this Feb 11, 2026
Copilot AI review requested due to automatic review settings February 11, 2026 14:12
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @karelz, @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds comprehensive threat model and implementation design documentation for System.Uri and System.UriBuilder. These documents are intended to be referenced from public documentation and provide detailed security considerations, implementation details, and usage guidelines for developers working with URI parsing and construction.

Changes:

  • Adds detailed threat model documentation for System.Uri covering parsing behavior, security considerations, algorithmic complexity, thread safety, and custom parsers
  • Adds threat model documentation for System.UriBuilder covering construction, property validation, and security considerations
  • Documents are placed in src/libraries/System.Private.Uri/docs/ following the pattern of other security documentation in the repository

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/libraries/System.Private.Uri/docs/System.Uri Threat Model.md Comprehensive 517-line threat model covering Uri parsing phases, component validation, normalization, security considerations, algorithmic complexity guarantees, thread safety, custom parsers, and fuzzing
src/libraries/System.Private.Uri/docs/System.UriBuilder Threat Model.md 141-line threat model documenting UriBuilder's mutable builder pattern, component validation, property behavior, and security considerations for URI construction

Copilot AI review requested due to automatic review settings February 24, 2026 13:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

@MihaZupan MihaZupan enabled auto-merge (squash) February 24, 2026 13:48
@MihaZupan MihaZupan merged commit 97de220 into main Feb 24, 2026
160 of 162 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants