Publish Uri and UriBuilder threat models#124273
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive threat model and implementation design documentation for System.Uri and System.UriBuilder. These documents are intended to be referenced from public documentation and provide detailed security considerations, implementation details, and usage guidelines for developers working with URI parsing and construction.
Changes:
- Adds detailed threat model documentation for
System.Uricovering parsing behavior, security considerations, algorithmic complexity, thread safety, and custom parsers - Adds threat model documentation for
System.UriBuildercovering construction, property validation, and security considerations - Documents are placed in
src/libraries/System.Private.Uri/docs/following the pattern of other security documentation in the repository
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/libraries/System.Private.Uri/docs/System.Uri Threat Model.md |
Comprehensive 517-line threat model covering Uri parsing phases, component validation, normalization, security considerations, algorithmic complexity guarantees, thread safety, custom parsers, and fuzzing |
src/libraries/System.Private.Uri/docs/System.UriBuilder Threat Model.md |
141-line threat model documenting UriBuilder's mutable builder pattern, component validation, property behavior, and security considerations for URI construction |
This was referenced Feb 11, 2026
AustinWise
reviewed
Feb 12, 2026
src/libraries/System.Private.Uri/docs/System.Uri Threat Model.md
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.Uri/docs/System.Uri Threat Model.md
Outdated
Show resolved
Hide resolved
ManickaP
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are a mix of threat model / implementation design doc.
I'll link to this from public docs once it's merged.
The Fuzzing section refers to a non-existent file for now since I'm waiting on #123932 to get merged first.