Add an ASCII check for edge-case non-ASCII hosts that can't be Punycode encoded#123934
Merged
MihaZupan merged 2 commits intodotnet:mainfrom Feb 3, 2026
Merged
Add an ASCII check for edge-case non-ASCII hosts that can't be Punycode encoded#123934MihaZupan merged 2 commits intodotnet:mainfrom
MihaZupan merged 2 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
ManickaP
approved these changes
Feb 3, 2026
rzikm
reviewed
Feb 3, 2026
This was referenced Feb 3, 2026
rzikm
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an edge-case where some hosts that exceed DNS limits (e.g. contain long labels) can't get Punycode encoded, and their
IdnHostmay return a non-ASCII value.This broke some assumptions in our HTTP logic where we'd hit debug asserts.