[LoongArch64] Align PR#108419: Verify TLS resolver code for LA64. #122767
+107
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `-mtls-dialect=desc` compile parameters for TestTLSWithLoadedDlls.sh to enble `R_LARCH_TLS_DESC6` relocation type.
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
LuckyXu-HF
commented
Dec 29, 2025
|
|
||
| install (TARGETS usetls DESTINATION bin) | ||
|
|
||
| if(CLR_CMAKE_TARGET_ARCH_LOONGARCH64) |
Contributor
Author
There was a problem hiding this comment.
On LoongArch64 will catch the error of TestTLSWithLoadedDlls.sh under debug mode:
TestTLSWithLoadedDlls.sh failed output
BEGIN EXECUTION
/data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root//corerun -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true TestTLSWithLoadedDlls.dll ''
Launching /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root/corerun -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/0/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/1/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/2/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/3/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/4/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/5/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/6/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/7/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/8/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/9/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/10/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/11/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/12/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/13/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/14/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/15/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/16/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/17/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/18/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/19/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/20/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/21/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/22/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/23/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/24/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/25/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/26/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/27/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/28/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/29/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/30/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/31/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/32/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/33/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/34/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/35/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/36/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/37/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/38/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/39/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/40/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/41/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/42/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/43/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/44/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/45/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/46/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/47/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/48/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/49/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/50/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/51/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/52/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/53/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/54/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/55/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/56/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/57/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/58/libusetls.so -l /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/59/libusetls.so /data/xuliangyu/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/JIT/Directed/tls/TestTLSWithLoadedDlls/TestTLSWithLoadedDlls.dll RunLotsOfTasks
ASSERT FAILED
Expression: !"Detected static resolver in use when not expected"
Location: line 956 in /data/xuliangyu/runtime/src/coreclr/vm/threadstatics.cpp
Function: CanJITOptimizeTLSAccess
Process: 1650216
Expected: 100
Actual: 134
END EXECUTION - FAILEDThe TLS descriptor is disabled by default for LA64's clang and gcc. So we need to add this compile parameters to make the thread static variables to use R_LARCH_TLS_DESC6 relocation type to match the TestTLSWithLoadedDlls.sh test mechanism.
Contributor
Author
|
@shushanhf @jkotas could you please help to review this PR? Thanks. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-mtls-dialect=desccompile parameters for TestTLSWithLoadedDlls.sh to enbleR_LARCH_TLS_DESC6relocation type.