[clr-interp] Tracing fixes. #122467
Open
[clr-interp] Tracing fixes. #122467
+189
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta, and update event_pipe to be a bit more resilient to interpreter codegen patterns - Fix rundown to be able to walk the interpreter code heaps - Fix the CodeHeapIterator implementation to have a correct move constructor/move operator - Tweak the eventpipe code to be able to ignore stack frames without a control_pc - Adjust rundownvalidation test to print out what condition failed. This fixes BinderTracingTest.ResolutionFlow and rundownvalidation
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes interpreter-related tracing issues by enabling rundown to walk interpreter code heaps and making event pipe more resilient to interpreter codegen patterns.
- Adds support for iterating over interpreter code heaps during rundown in addition to JIT heaps
- Fixes CodeHeapIterator to support move semantics correctly with proper resource management
- Updates event pipe stack walking to handle frames without valid control_pc values
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs | Adds diagnostic logging to print out which rundown event conditions failed |
| src/coreclr/vm/eventtrace.cpp | Extends rundown to iterate both JIT and interpreter code heaps, and fixes code version checking to work with interpreter code |
| src/coreclr/vm/eventing/eventpipe/ep-rt-coreclr.cpp | Updates stack walk callback to skip frames without valid control_pc and adds debug assertions for expected scenarios |
| src/coreclr/vm/codeman.h | Refactors CodeHeapIterator to use RAII holder for proper resource management and adds m_codeType field to track code type |
| src/coreclr/vm/codeman.cpp | Implements the RAII holder for CodeHeapIterator and adds logic to distinguish between JIT and interpreter code headers |
This was referenced Dec 12, 2025
Member
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rundown to dump the interpreter generated code data, and update event_pipe to be a bit more resilient to interpreter codegen patterns
This fixes BinderTracingTest.ResolutionFlow and rundownvalidation