[browser] Generate boot config with hash field instead of integrity #122353
+30
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
maraf
changed the title
This was referenced Dec 9, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression from #116300 by renaming the integrity field to hash in the boot configuration classes and their usage. The JavaScript runtime expects assets to have a hash field, which was incorrectly changed to integrity in the previous PR.
Key Changes:
- Renamed property from
integritytohashin three asset classes:WasmAsset,GeneralAsset, andVfsAsset - Updated all property assignments in
BootJsonBuilderHelper.csto use thehashfield name - Added test case to verify that assets have integrity/hash values
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/BootJsonData.cs | Renamed integrity property to hash in WasmAsset, GeneralAsset, and VfsAsset classes |
| src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/BootJsonBuilderHelper.cs | Updated all property assignments from integrity to hash when creating asset instances |
| src/mono/wasm/testassets/WasmBasicTestApp/App/wwwroot/main.js | Added new test case "AssetIntegrity" to log integrity values for all assets via resource loader |
| src/mono/wasm/Wasm.Build.Tests/ModuleConfigTests.cs | Added test method to verify that non-JS/non-JSON assets have integrity hash values |
pavelsavara
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript part of .NET expects assets to have field
hash. This PR unifies it between internal structure and boot config generated during build. It is a regression from boot config structure change from #116300.This PR will cause failure of some tests once it flows to dotnet/sdk.
This PR will be a candidate for backport to 10.0.
Fixes #121876