[browser] Map integrity from boot config to asset hash #122290
Draft
+41
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #121876 by mapping the integrity property from boot config to the internal hash property used by asset loading. The changes rename the public-facing hash field to integrity in asset type definitions while maintaining backward compatibility by internally mapping integrity to hash in the loader.
Key Changes
- Renamed
hashtointegrityin public asset type definitions (WasmAsset, AssemblyAsset, PdbAsset, VfsAsset, IcuAsset) - Added runtime mapping logic to convert
integritytohashfor internal use in asset loading - Added test case to verify assets have integrity values
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mono/browser/runtime/types/index.ts | Renamed hash property to integrity in asset type definitions |
| src/mono/browser/runtime/dotnet.d.ts | Updated TypeScript declarations to reflect integrity property rename |
| src/mono/browser/runtime/loader/assets.ts | Added logic to map integrity to internal hash property in two places |
| src/mono/wasm/Wasm.Build.Tests/ModuleConfigTests.cs | Added test to verify assets have integrity values |
| src/mono/wasm/testassets/WasmBasicTestApp/App/wwwroot/main.js | Added test case handler and exit condition for AssetIntegrity test |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
4 tasks
Member
Author
|
Based on offline discussion, we might want to fix the problem differently |
maraf
added
the
NO-MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assets generated by boot config generator contains field
integrity, but internal assets structure contains fieldhash. This PR copies the value fromintegritytohashto minimize the diff. It is a regression from boot config structure change from #116300.Fixes #121876