Skip to content

[DRAFT][WIP]Add Zip Archives password support #122093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
alinpahontu2912 wants to merge 39 commits into
base: main
Choose a base branch
from
Draft

[DRAFT][WIP]Add Zip Archives password support #122093

alinpahontu2912 wants to merge 39 commits into from

Conversation

@alinpahontu2912
Copy link
Member

@alinpahontu2912 alinpahontu2912 commented Dec 2, 2025 •
edited
Loading

Fixes #1545

Big Milestones and status:

  • Read Encrypted Entries (ZipCrypto, WinZip AES)
  • Create Encrypted Entries (ZipCrypto, Winzip AES)
  • Add runtime assets for checking compat with WinRar/7zip/WinZip/etc
  • Update Mode
  • Security check for Cryptography methods
  • Final API design

@alinpahontu2912
working zipcrypto, hardcoded password
527c698
@alinpahontu2912
add tests with multiple entries with same password and entries with p…
255642b 
…assword and unprotected
@alinpahontu2912
reading/extracting experimentation and tests
968bb60
@alinpahontu2912
add enum for encryption and write methods for zipcrypto stream
19cbc8e
@alinpahontu2912
allow encryption of entries
0dec737
@alinpahontu2912
add more read/write tests for update mode and small refactors
f30fbfb
@alinpahontu2912
add default password and encryption method to ziparchive
aac140b
@alinpahontu2912
avoid ambigous calls
eb1a460
@alinpahontu2912
avoid ambigous calls and fi some nitpicks
0a7c885
@alinpahontu2912
recognize aes encrypted files + build fais due to circular dependency…
817165c 
… with cryptography lib
@alinpahontu2912
fixed some comments
797921d
@alinpahontu2912
remove storing password fields
623f238
@alinpahontu2912
initial reading of winzip encrypted files
b61b37c
@alinpahontu2912
address zipcrypto comments
122f85a
@alinpahontu2912
initial writing test works
55c0613
@alinpahontu2912
add more tests for winzipaesstream and work on async methods
cc6d30d
@alinpahontu2912
Merge remote-tracking branch 'upstream/main' into zip_password
b056780
@alinpahontu2912
async methods done, fix ae-1 validation and add more tests
6732696
@alinpahontu2912
Solve some comments
8efa772
@alinpahontu2912
refactor tests and ci disable local ones
d5bb294
@alinpahontu2912
improve winzipaesstream writing by generating larger keystream
0c659fc
@alinpahontu2912
update tests, fixed async opening and updated stream positioning
e2b21ff
This was referenced Dec 2, 2025
Open
Open
Open
@rzikm rzikm self-requested a review December 11, 2025 12:22
rzikm
rzikm reviewed Dec 11, 2025
View reviewed changes
rzikm
rzikm reviewed Dec 11, 2025
View reviewed changes
@rzikm rzikm added this to the 11.0.0 milestone Dec 11, 2025
rzikm
rzikm reviewed Dec 11, 2025
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Dec 12, 2025
Open
@build-analysis build-analysis bot mentioned this pull request Jan 6, 2026
Open
This was referenced Jan 14, 2026
Open
Open
rzikm
rzikm reviewed Jan 14, 2026
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Jan 15, 2026
Open
3 tasks
This was referenced Jan 19, 2026
Open
Open
This was referenced Jan 22, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rzikm rzikm rzikm left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@alinpahontu2912 alinpahontu2912

Labels

area-System.IO.Compression

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

Add password to ZipArchive

2 participants

@alinpahontu2912 @rzikm