Use AllocateUninitializedArray for primitive types except bool in SharedArrayPool

[Copilot]

ArrayPool now uses a conditional allocation strategy to balance performance and safety. Primitive types (excluding bool) use uninitialized arrays for better performance, while bool and non-primitive types use initialized arrays.

Changes

• SharedArrayPool<T>.Rent(): Changed to use conditional allocation (lines 110-112):
  • Primitive types (excluding bool): Uses GC.AllocateUninitializedArray<T>() for performance
  • bool and non-primitive types: Uses new T[] for safety
• ConfigurableArrayPool<T> already used new T[] and is unchanged

This approach optimizes performance for primitive types where any bit pattern is valid, while ensuring proper initialization for bool (which has problematic bit patterns) and all reference/value types.

Original prompt

ArrayPool currently uses GetUninitializedArray. This makes some array allocations faster, but arrays should only be allocated rarely. Please switch it to just using new T[].

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[jkotas]

Thanks

[Copilot]

Pull Request Overview

This PR optimizes array allocation in SharedArrayPool<T> by using uninitialized arrays for primitive types (except bool) while maintaining safety for other types. Previously, all array allocations used GC.AllocateUninitializedArray, which could produce invalid bit patterns for bool and non-primitive types.

Key Changes:

• Added conditional allocation logic that uses GC.AllocateUninitializedArray<T>() for primitive types excluding bool, and new T[] for bool and all other types
• Improves safety by ensuring bool arrays and reference/value types are properly initialized
• Maintains performance benefits of uninitialized allocation for most primitive types