Clear contained flag in sign test optimization #121782
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Copilot finished reviewing on behalf of
EgorBo
November 19, 2025 08:35
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #121723 by clearing the contained flag in the sign test optimization for ARM64. The optimization removes unnecessary casts to TYP_BYTE or TYP_SHORT when comparing values against zero in the JIT's lowering phase.
Key changes:
- Added
castOp->ClearContained()call to properly mark the cast operand as non-contained after unwrapping the cast - Updated API usage from direct field access to the
CastToType()accessor method
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jakobbotsch
approved these changes
Nov 19, 2025
This was referenced Nov 19, 2025
Member
Author
|
/ba-g outerloop failures are #121699 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121723