Add context argument to crash dump functions to preserve register state #121773
+55
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add context argument to crash dump methods
Add context argument to crash dump functions to preserve register state
Nov 19, 2025
Copilot finished work on behalf of
jkotas
November 19, 2025 04:19
jkotas
reviewed
Nov 19, 2025
jkotas
reviewed
Nov 19, 2025
Instead of using a volatile variable, create a helper function marked with noinline and no-optimization attributes that accepts the address of the context pointer. This ensures the context is properly preserved in crash dumps and not optimized away by the compiler. Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Updated PROCAbort to accept a context parameter and modified all call sites in signal handlers to pass the context pointer where it is available. This ensures context information is preserved in crash dumps when aborting. Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Copilot finished work on behalf of
jkotas
November 19, 2025 07:02
jkotas
reviewed
Nov 19, 2025
Renamed the helper function to DoNotOptimize with a const void* parameter to make it more general-purpose and not specific to context pointers. Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Copilot finished work on behalf of
jkotas
November 19, 2025 07:44
jkotas
added
area-PAL-coreclr
and removed
needs-area-label
jkotas
requested review from
Copilot
and removed request for
MichalStrehovsky and
Copilot
janvorli
reviewed
Nov 19, 2025
janvorli
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add context argument to PalCreateCrashDumpIfEnabled and PROCCreateCrashDumpIfEnabled methods
This PR addresses the issue where the context pointer is missing in crash dumps, making diagnosis difficult.
Contributes to #119761