Skip to content

Conversation

@MichalStrehovsky
Copy link
Member

No description provided.

@MichalStrehovsky MichalStrehovsky added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 14, 2025
Copilot finished reviewing on behalf of MichalStrehovsky November 14, 2025 07:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a typo in the JIT compiler's intrinsic detection logic that prevented proper recognition of the ConfigureAwait method on ValueTask<T>. The typo "ValuTask1" has been corrected to "ValueTask1", ensuring the intrinsic optimization can be applied correctly.

Key Changes

  • Corrected spelling from "ValuTask1" to "ValueTask1" in the intrinsic lookup logic for ConfigureAwait

Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that should fix #121564 (comment)

@VSadov
Copy link
Member

VSadov commented Nov 14, 2025

I have seen this typo and I thought I have fixed it in #120704. But somehow the fix for the typo did not make it.

Most likely I tested the fix in the Libraries PR with bunch of other fixes, but when I cherrypicked the commits into a standalone PR with just patternmatch implementation for ValueTask.ConfigureAwait, I missed the typo fix for the generic intrinsic.

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI runtime-async

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants